feat(smus): UX improvements for connecting running spaces from toolkit #8261

bhavya2109sharma · 2025-11-05T23:52:39Z

Problem

Connect button only appeared for spaces with remote access enabled. When users landed on the toolkit and saw running spaces without remote access, there was no connect button visible. This created confusion because:
-- Users expected to be able to connect to any running space
-- No visual indication that connection was possible
-- Users didn't understand why some spaces were "connectable" and others weren't

Solution

Always show connect button for all spaces (running and stopped, regardless of remote access status). When users click connect on a space without remote access, show clear dialog explaining what needs to happen and get their consent upfront.
There is no breaking change.
Tested for all use-cases SM-AI and SMUS

Current User Exp

Screen.Recording.2025-11-05.at.3.23.39.PM.mov

Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
Your code changes must meet the guidelines in CONTRIBUTING.md.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions · 2025-11-05T23:52:55Z

This pull request modifies code in src/* but no tests were added/updated.
- Confirm whether tests should be added or ensure the PR description explains why tests are not required.
This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
- Note: beta or "experiment" features that have active users should announce fixes in the changelog.
- If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

packages/core/src/awsService/sagemaker/commands.ts

packages/core/src/awsService/sagemaker/sagemakerSpace.ts

laileni-aws

Its better to add change log for this !

packages/core/src/awsService/sagemaker/commands.ts

vpbhargav · 2025-11-06T19:52:03Z

packages/core/src/awsService/sagemaker/commands.ts

+        }
+
+        // Get current instance type
+        const requestedResourceSpec =


Nit : "requestedResourceSpec" - Is this called in the update flow? If not, the "requested" part is misleading.

packages/core/src/awsService/sagemaker/commands.ts

vpbhargav · 2025-11-06T19:56:15Z

packages/core/src/awsService/sagemaker/commands.ts

+        )
+    } else {
+        // Only remote access needs to be enabled
+        prompt = `This space requires remote access to be enabled.\nWould you like to restart the space and connect?\nAny unsaved work will be lost.`


Can we move this to a constant where existing error messages are managed please?

packages/core/src/awsService/sagemaker/commands.ts

vpbhargav · 2025-11-06T19:59:08Z

packages/core/src/awsService/sagemaker/commands.ts

+                })
+
+                // Update progress message
+                progress.report({ message: 'Starting the space' })


Nit : Can maybe include the new instanceType in the case we are also upgrading instance type.

packages/core/src/awsService/sagemaker/commands.ts

vpbhargav · 2025-11-06T20:05:26Z

packages/core/src/awsService/sagemaker/sagemakerSpace.ts

+        let baseTooltip = ''
        if (this.isSMUSSpace) {
-            return `**Space:** ${spaceName} \n\n**Application:** ${appType} \n\n**Instance Type:** ${instanceType}`
+            baseTooltip = `**Space:** ${spaceName} \n\n**Application:** ${appType} \n\n**Instance Type:** ${instanceType}`


Thanks for updating this!

packages/core/src/awsService/sagemaker/sagemakerSpace.ts

vpbhargav

Please test thoroughly for both SMUS and SMAI, thanks for making this improvement!

packages/toolkit/.changes/next-release/feature-smus-ux-improvements.json

dylanraws · 2025-11-07T20:56:14Z

packages/core/src/test/awsService/sagemaker/commands.test.ts

+
+                // Setup test window to handle confirmation dialog
+                getTestWindow().onDidShowMessage((message) => {
+                    if (message.message.includes('remote access')) {


I would find this easier to understand what we are testing if I could see a little bit more of the message we are matching. If we have a constant for the message, we can simply reference it here.

bhavya2109sharma requested a review from a team as a code owner November 5, 2025 23:52

kzr-at-amazon reviewed Nov 6, 2025

View reviewed changes

packages/core/src/awsService/sagemaker/commands.ts Outdated Show resolved Hide resolved

bhavya2109sharma force-pushed the feature/smus-ux-improvements branch from 1a5a7cf to 3cfbdfe Compare November 6, 2025 00:11

kzr-at-amazon reviewed Nov 6, 2025

View reviewed changes

packages/core/src/awsService/sagemaker/commands.ts Show resolved Hide resolved

kzr-at-amazon reviewed Nov 6, 2025

View reviewed changes

packages/core/src/awsService/sagemaker/commands.ts Show resolved Hide resolved

kzr-at-amazon approved these changes Nov 6, 2025

View reviewed changes

dylanraws reviewed Nov 6, 2025

View reviewed changes

laileni-aws requested changes Nov 6, 2025

View reviewed changes

vpbhargav reviewed Nov 6, 2025

View reviewed changes

packages/core/src/awsService/sagemaker/commands.ts Outdated Show resolved Hide resolved

vpbhargav reviewed Nov 6, 2025

View reviewed changes

dylanraws approved these changes Nov 7, 2025

View reviewed changes

bhavya2109sharma force-pushed the feature/smus-ux-improvements branch 2 times, most recently from 7a4f4cd to 03358a7 Compare November 7, 2025 07:57

bhavya2109sharma requested a review from laileni-aws November 7, 2025 07:58

vpbhargav reviewed Nov 7, 2025

View reviewed changes

packages/core/src/awsService/sagemaker/sagemakerSpace.ts Show resolved Hide resolved

vpbhargav approved these changes Nov 7, 2025

View reviewed changes

laileni-aws reviewed Nov 7, 2025

View reviewed changes

packages/toolkit/.changes/next-release/feature-smus-ux-improvements.json Show resolved Hide resolved

laileni-aws approved these changes Nov 7, 2025

View reviewed changes

laileni-aws enabled auto-merge (squash) November 7, 2025 18:03

auto-merge was automatically disabled November 7, 2025 20:23
Head branch was pushed to by a user without write access

bhavya2109sharma force-pushed the feature/smus-ux-improvements branch 2 times, most recently from c0b5314 to e0278f5 Compare November 7, 2025 20:58

dylanraws approved these changes Nov 7, 2025

View reviewed changes

feat(smus): UX improvements for connecting running spaces from toolkit

0e8e53a

bhavya2109sharma force-pushed the feature/smus-ux-improvements branch from e0278f5 to 0e8e53a Compare November 7, 2025 21:30

Will-ShaoHua approved these changes Nov 7, 2025

View reviewed changes

Will-ShaoHua merged commit df9ef5d into aws:master Nov 7, 2025
30 of 31 checks passed

dylanraws mentioned this pull request Nov 11, 2025

fix(sagemaker): Disable start/stop button for intermediate state of the space #8282

Merged

feat(smus): UX improvements for connecting running spaces from toolkit #8261

feat(smus): UX improvements for connecting running spaces from toolkit #8261

Conversation

bhavya2109sharma commented Nov 5, 2025

Problem

Solution

Current User Exp

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

laileni-aws left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vpbhargav Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vpbhargav Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vpbhargav Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vpbhargav Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vpbhargav left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dylanraws Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

bhavya2109sharma Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants